fix: rename tmp directory to data for saved chats - Fixes #14896
Summary
Fixes #14896
Changes
- Renamed
TMP_DIR_NAMEfrom'tmp'to'data'instorage.ts - Updated
storage.test.tsto match - Updated all documentation references (7 files)
Why
The tmp directory name was confusing as it suggested temporary/volatile storage, which could lead to accidental deletion of valuable saved chats.
Summary of Changes
Hello @liqzheng, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a potential source of confusion by renaming the directory used for storing persistent user data, such as saved chats and session history, from 'tmp' to 'data'. The previous 'tmp' designation misleadingly suggested volatile storage, which could lead users to accidentally delete valuable information. The change clarifies the directory's purpose, ensuring that users understand the data stored there is intended to be permanent.
Highlights
-
Core Logic Change: The internal constant
TMP_DIR_NAMEinpackages/core/src/config/storage.tshas been renamed from'tmp'to'data'to better reflect its purpose of storing persistent user data like saved chats. -
Test Updates: The corresponding test file
packages/core/src/config/storage.test.tswas updated to reflect the new directory name in its test assertions. -
Documentation Alignment: Seven documentation files across
docs/cli/anddocs/get-started/were updated to replace references to~/.gemini/tmp/with~/.gemini/data/, ensuring consistency with the new naming convention.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Summary
Fixes #14896
Changes
- Renamed
TMP_DIR_NAMEfrom'tmp'to'data'instorage.ts- Updated
storage.test.tsto match- Updated all documentation references (7 files)
Why
The
tmpdirectory name was confusing as it suggested temporary/volatile storage, which could lead to accidental deletion of valuable saved chats.
Hi @liqzheng,
Thanks for addressing #14896. This change looks good for clarifying the storage location of saved chats.
However, I noticed that renaming tmp to data for the saved chats directory (e.g., from
~/.gemini/tmp/<project_hash>/ to ~/.gemini/data/<project_hash>/) will likely cause users to lose any chat
they have previously saved. The current saved chats in the tmp directory will no longer be accessible throu
the new data path.
Did you consider a migration strategy for existing saved chats, or is this intended to be a breaking change that resets existing saved chat history? It would be good to clarify this for users.
Thanks for your work on this!
Summary
Fixes #14896
Changes
- Renamed
TMP_DIR_NAMEfrom'tmp'to'data'instorage.ts- Updated
storage.test.tsto match- Updated all documentation references (7 files)
Why
The
tmpdirectory name was confusing as it suggested temporary/volatile storage, which could lead to accidental deletion of valuable saved chats.Hi @liqzheng,
Thanks for addressing #14896. This change looks good for clarifying the storage location of saved chats.
However, I noticed that renaming
tmptodatafor the saved chats directory (e.g., from~/.gemini/tmp/<project_hash>/to~/.gemini/data/<project_hash>/) will likely cause users to lose any chat they have previously saved. The current saved chats in thetmpdirectory will no longer be accessible throu the newdatapath.Did you consider a migration strategy for existing saved chats, or is this intended to be a breaking change that resets existing saved chat history? It would be good to clarify this for users.
Thanks for your work on this!
@samucodesh I've added a migration function that automatically moves existing chats from tmp/ to data/ on first run. Users won't lose their saved chats.
Thank you for the PR but we do not plan to change this at this time.