[WIP] Migrate display of banner logic from Mendel to GCA events
Summary
Based on this design doc, we have decided to shift away from using Mendel as the place for storing banner data as remote config to GCA events which is more suitable for our use case.
Details
On startup we fetch events.
Related Issues
How to Validate
After the cl for adding the banner campaigns has been submitted, we will test locally.
Pre-Merge Checklist
- [ ] Updated relevant documentation and README (if needed)
- [ ] Added/updated tests (if needed)
- [ ] Noted breaking changes (if any)
- [ ] Validated on required platforms/methods:
- [ ] MacOS
- [X] npm run
- [ ] npx
- [ ] Docker
- [ ] Podman
- [ ] Seatbelt
- [ ] Windows
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] Linux
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] MacOS
Summary of Changes
Hello @Adib234, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request overhauls the banner display functionality within the CLI application. It shifts the source of banner configuration from a legacy remote config system to a more suitable GCA events-based approach. This change streamlines the data flow for banners, simplifies the UI state management, and introduces a dedicated event fetching and caching layer to support the new system.
Highlights
- Banner Logic Migration: The system for displaying banners has been migrated from using Mendel (remote config) to GCA events, aligning with a new design document.
- New Event Fetching Mechanism: A new mechanism has been introduced to fetch and cache events from the server on startup, specifically for banner data.
-
Simplified Banner Data Structure: The internal representation of banner data has been simplified from separate
defaultTextandwarningTextto a unifiedbannerTextandisWarningflag. -
Removal of Persistent State Logic: The logic for tracking banner display counts and managing persistent state for banners has been removed, simplifying the
useBannerhook and related components. -
API Integration for Events: The
CodeAssistServernow includes areceiveEventsmethod, and theConfigclass has been updated to manage and retrieve these new GCA events.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Size Change: -709 B (0%)
Total Size: 22.3 MB
ℹ️ View Unchanged
| Filename | Size | Change |
|---|---|---|
./bundle/gemini.js |
22.3 MB | -709 B (0%) |
./bundle/sandbox-macos-permissive-closed.sb |
1.03 kB | 0 B |
./bundle/sandbox-macos-permissive-open.sb |
890 B | 0 B |
./bundle/sandbox-macos-permissive-proxied.sb |
1.31 kB | 0 B |
./bundle/sandbox-macos-restrictive-closed.sb |
3.29 kB | 0 B |
./bundle/sandbox-macos-restrictive-open.sb |
3.36 kB | 0 B |
./bundle/sandbox-macos-restrictive-proxied.sb |
3.56 kB | 0 B |
/gemini review
Merge after this CL gets submitted https://critique.corp.google.com/cl/846289711