gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

Refactor/editor types single source of truth

Open aka1976mb opened this issue 2 months ago • 1 comments

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • [ ] Updated relevant documentation and README (if needed)
  • [ ] Added/updated tests (if needed)
  • [ ] Noted breaking changes (if any)
  • [ ] Validated on required platforms/methods:
    • [ ] MacOS
      • [ ] npm run
      • [ ] npx
      • [ ] Docker
      • [ ] Podman
      • [ ] Seatbelt
    • [ ] Windows
      • [ ] npm run
      • [ ] npx
      • [ ] Docker
    • [ ] Linux
      • [ ] npm run
      • [ ] npx
      • [ ] Docker

aka1976mb avatar Dec 06 '25 00:12 aka1976mb

Summary of Changes

Hello @aka1976mb, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the management of the Gemini API key by introducing a direct configuration option and establishing a clear hierarchy for its retrieval. This ensures consistency and predictability in how the API key is sourced across different environments. Additionally, the changes include updates to the project's dependency lock file, likely to standardize peer dependency declarations, and minor enhancements to the VS Code development environment.

Highlights

  • Gemini API Key Configuration: Introduced a new geminiApiKey field in the configuration schema and ConfigParameters interface, allowing the Gemini API key to be set directly within the application's configuration.
  • API Key Resolution Priority: Updated the logic for resolving the Gemini API key to establish a clear precedence: the geminiApiKey from the Config object is now prioritized, followed by a key loaded from credential storage, and then the GEMINI_API_KEY environment variable.
  • New Test Coverage for API Key Handling: Added a dedicated test file (geminiApiKey.test.ts) to thoroughly validate the new Gemini API key configuration logic, including the priority order of key sources and ensuring that the API key is masked when used in proxy configurations to prevent accidental leakage.
  • Dependency Lock File Updates: Numerous peer: true flags were added or removed for various dependencies within package-lock.json. This likely reflects an update or standardization of how peer dependencies are declared and managed in the project's dependency tree.
  • VS Code Developer Experience Improvements: Added new settings to .vscode/settings.json to ignore the main branch for GitHub Pull Requests and enabled Copilot's next edit suggestions, enhancing the developer workflow within VS Code.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/config.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 06 '25 00:12 gemini-code-assist[bot]

Hi @aka1976mb, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

bdmorgan avatar Jan 15 '26 03:01 bdmorgan