gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

fix: correct API key precedence and CODEOWNERS syntax

Open aka1976mb opened this issue 2 months ago • 1 comments

Automated PR to address:

  • Correct API key precedence in contentGenerator.ts
  • Standardize CODEOWNERS syntax

aka1976mb avatar Dec 06 '25 00:12 aka1976mb

Summary of Changes

Hello @aka1976mb, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the configuration handling for API keys and Google Cloud project/location settings within the content generation module, ensuring correct precedence for API key loading and enabling more granular control for Vertex AI configurations. Additionally, it streamlines the CODEOWNERS file for better maintainability and clarity.

Highlights

  • API Key Precedence: The logic for loading the geminiApiKey in contentGenerator.ts has been updated to prioritize the key provided in the configuration object (config.geminiApiKey) over environment variables and loaded API keys.
  • CODEOWNERS Simplification: The .github/CODEOWNERS file has been simplified by removing specific file-based review requirements, retaining only the default maintainer assignment for all files.
  • Google Cloud Project/Location Support: Added support for googleCloudProject and googleCloudLocation within the ContentGeneratorConfig and ensured these values are passed to the GoogleGenAI client when Vertex AI is utilized.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 06 '25 00:12 gemini-code-assist[bot]

Hi @aka1976mb, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

bdmorgan avatar Jan 15 '26 03:01 bdmorgan