fix(core): improve API response error handling and retry logic
- Always retry on transient network error codes (e.g., ETIMEDOUT, ECONNRESET) regardless of retryFetchErrors setting.
- Update WebFetchTool to use retryWithBackoff for fallback fetch operations to handle rate limits (429) and server errors (500s) robustly.
- Add comprehensive tests for retry logic and WebFetchTool error handling.
Summary of Changes
Hello @mattKorwel, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves the reliability of external API calls within the core library by implementing more sophisticated error handling and retry mechanisms. It ensures that critical network failures are always retried and integrates a backoff strategy for various HTTP errors, making the system more resilient to transient issues and external service disruptions.
Highlights
-
Enhanced Network Error Retries: Transient network error codes (e.g., ETIMEDOUT, ECONNRESET) will now always trigger a retry, irrespective of the
retryFetchErrorsconfiguration setting, ensuring greater resilience against intermittent connectivity issues. -
Robust WebFetchTool Integration: The
WebFetchToolhas been updated to utilize theretryWithBackoffutility for all its fetch operations, providing a more robust handling of HTTP errors such as rate limits (429) and server errors (500s). -
Comprehensive Test Coverage: New and updated tests have been added to thoroughly validate the improved retry logic and error handling within the
WebFetchTooland theretryWithBackoffutility, including specific scenarios for network error codes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Size Change: +754 B (0%)
Total Size: 21.5 MB
ℹ️ View Unchanged
| Filename | Size | Change |
|---|---|---|
./bundle/gemini.js |
21.5 MB | +754 B (0%) |
./bundle/sandbox-macos-permissive-closed.sb |
1.03 kB | 0 B |
./bundle/sandbox-macos-permissive-open.sb |
890 B | 0 B |
./bundle/sandbox-macos-permissive-proxied.sb |
1.31 kB | 0 B |
./bundle/sandbox-macos-restrictive-closed.sb |
3.29 kB | 0 B |
./bundle/sandbox-macos-restrictive-open.sb |
3.36 kB | 0 B |
./bundle/sandbox-macos-restrictive-proxied.sb |
3.56 kB | 0 B |