feat(core): Implement JIT context memory loading and UI sync
TLDR
Refactors memory loading to support the Experimental JIT Context feature. It introduces a unified refresh() method in ContextManager for JIT mode, ensures the UI receives updates via events, and properly includes environment memory (and MCP instructions) in the system context.
Dive Deeper
-
ContextManager Refactor: Introduced a
refresh()method to unify memory reloading (Global + Environment) and event emission. Removed legacyloadGlobalMemorycalls from Config initialization. -
Config Delegation:
Configdelegates memory state retrieval (file count, paths) toContextManagerwhen JIT is enabled. -
Event Optimization: Simplified
MemoryChangedevent to only emitfileCount, as content and paths are pulled from Config on demand or not required for simple UI updates. -
Memory Refresh: Updated
/memory refreshcommand to useContextManager.refresh()when JIT is enabled. -
System Context:
getEnvironmentContextnow includes the content of loaded environment memory files. MCP instructions are appended to environment memory in JIT mode.
Reviewer Test Plan
-
Enable JIT: Set
experimental.jitContext: truein settings. - Startup: Launch the CLI. Verify that the "Using: X GEMINI.md files" indicator appears and shows the correct count.
-
Context: Run
/resetand start a chat. Verify (via debug logs or model response) that the system instruction includes content from yourGEMINI.mdfiles AND any active MCP server instructions. -
Refresh: Modify a
GEMINI.mdfile and run/memory refresh. Verify the count updates and the model sees the new content. - Legacy: Disable JIT. Verify that memory loading works as before (using the CLI-side loader).
Testing Matrix
| đ | đĒ | đ§ | |
|---|---|---|---|
| npm run | â | â | â |
| npx | â | â | â |
| Docker | â | â | â |
| Podman | â | - | - |
| Seatbelt | â | - | - |
Linked issues / bugs
Summary of Changes
Hello @SandyTao520, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant refactoring to the application's memory loading and management system, primarily to enable and support an experimental Just-In-Time (JIT) context feature. The changes centralize memory handling within a new ContextManager class, ensuring that memory is loaded and refreshed consistently. It also establishes a mechanism for the UI to react to memory changes and integrates environment-specific memory directly into the system context provided to the model.
Highlights
- JIT Context Memory Loading: Memory loading has been refactored to support the experimental Just-In-Time (JIT) Context feature, centralizing memory management when JIT is enabled.
-
ContextManager Introduction: A new
ContextManagerclass is introduced to handle memory loading and management, including arefresh()method to unify memory reloading and event emission. -
UI Synchronization: The system now emits
MemoryChangedevents to ensure the UI properly reflects updates to loadedGEMINI.mdfiles, such as during JIT initialization or after a refresh. -
Config Delegation: The
Configclass now delegates memory state retrieval (user memory, file count, file paths) to theContextManagerwhenexperimentalJitContextis enabled, establishing a single source of truth. -
Enhanced System Context: The
getEnvironmentContextfunction now includes the content of loaded environment memory files, providing more comprehensive system instructions to the model.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Size Change: +1.67 kB (+0.01%)
Total Size: 22 MB
| Filename | Size | Change |
|---|---|---|
./bundle/gemini.js |
22 MB | +1.67 kB (+0.01%) |
âšī¸ View Unchanged
| Filename | Size |
|---|---|
./bundle/sandbox-macos-permissive-closed.sb |
1.03 kB |
./bundle/sandbox-macos-permissive-open.sb |
890 B |
./bundle/sandbox-macos-permissive-proxied.sb |
1.31 kB |
./bundle/sandbox-macos-restrictive-closed.sb |
3.29 kB |
./bundle/sandbox-macos-restrictive-open.sb |
3.36 kB |
./bundle/sandbox-macos-restrictive-proxied.sb |
3.56 kB |