alphageometry icon indicating copy to clipboard operation
alphageometry copied to clipboard

Is add_eq2 correct?

Open blackcherry88 opened this issue 1 year ago • 3 comments

Should it be self.add_expr([(a, n), (b, -m)])?

def add_eq2( self, a: str, b: str, m: float, n: float, dep: pr.Dependency ) -> None: # a/b = m/n if not self.add_expr([(a, m), (b, -n)]): return [] self.register2(a, b, m, n, dep)

blackcherry88 avatar Jan 31 '24 05:01 blackcherry88

Where is this code?

unhandyandy avatar Feb 05 '24 04:02 unhandyandy

Looks like it is here: https://github.com/google-deepmind/alphageometry/blob/main/ar.py#L425

I agree, it seems the dev makes a mistake there

bughunter244 avatar May 01 '24 20:05 bughunter244

Indeed this is a bug. I created a fork AG4Masses that fixed many issues in AlphaGeometry, including this one. Also added some additional features, documentation and idea on how to improve AG, check it out if you are interested.

I tested using a simple problem:

tt_rconst_bug
a b c = triangle12; d = midpoint a c ? cong a b a d

There is another bug related to constant ratio problems discussed in issue #111. To run the test problem correctly that bug also needs to be fixed.

tpgh24 avatar May 19 '24 21:05 tpgh24