redigo icon indicating copy to clipboard operation
redigo copied to clipboard

OpenTelemetry tracing manual instrumentation support

Open filipecosta90 opened this issue 4 years ago • 3 comments

In the same way as seen on the OpenTelemetry instrumentation forgo-redis it would be extremely beneficial to create a similar package for redigo. Not only we can track the overhead of the client code, but we can also precisely trace errors/latency spikes/timeouts/etc...

Some further info:

Important Note: Semantic conventions to follow while preparing a package for manual instrumentation.

While this is not mandatory, we should aim for standardization across clients/languages/DBs. Here's the spec on DB semantic conventions:

https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/redis.md

PS: will gladly contribute to this matter.

filipecosta90 avatar Jul 29 '21 21:07 filipecosta90

This should be totally possible within an external package.

stevenh avatar Aug 20 '23 11:08 stevenh

Related to https://github.com/gomodule/redigo/issues/642

stevenh avatar Jan 28 '24 14:01 stevenh

This is related to a similar conversation about adding slog support, which has me thinking about a https://github.com/gomodule/redigo/issues/656#issuecomment-1913298826 which should consider this use case as well.

Would like to hear peoples thoughts on that as an approach?

stevenh avatar Jan 28 '24 15:01 stevenh