yapapi icon indicating copy to clipboard operation
yapapi copied to clipboard

Add an integration test for the "failed to spawn instance" issue

Open filipgolem opened this issue 3 years ago • 2 comments

Issue: #922 PR: #929

To reproduce this issue, create_activity should return an error (e.g. 408) when the service is started.

filipgolem avatar Apr 14 '22 10:04 filipgolem

Could someone please fill in any details here to guide my research into this?

create_activity should return an error (e.g. 408) when the service is started.

The bug was fixed, so a test needs to be written just to confirm the expected outcome?

if an error happens in create_activity, agreement won't be set and Failed to spawn instance (a.k.a. This shouldn't happen) will be logged.

The problem was that when the Golem service was launched and an error occurred in create_activity, it was logging the wrong error (“Failed to spawn instance”) - it should have thrown a more accurate error.

So I should write a variety of tests checking for different things that can go wrong in create_activity, and make sure the proper errors are being thrown for them?

Thanks very much

swetepete avatar Apr 30 '22 10:04 swetepete

no, the point of this issue is to write a goth integration test that would be able to reproduce the original issue and at the same time ensure that yapapi is able to recover gracefully and spawn an instance

shadeofblue avatar May 04 '22 08:05 shadeofblue