yapapi icon indicating copy to clipboard operation
yapapi copied to clipboard

It is unknown how to set gftp service bus url properly

Open lucekdudek opened this issue 3 years ago • 0 comments

As for now, yapapi is passing GSB_URL implicitly via os.environ.

        env = dict(os.environ, RUST_LOG="debug") if self._debug else None
        self._proc = await asyncio.create_subprocess_shell(
            "gftp server", stdout=asyncio.subprocess.PIPE, stdin=asyncio.subprocess.PIPE, env=env
        )

https://github.com/golemfactory/yapapi/blob/b89b1323bf156466d884dc938937e36ccbdc8d75/yapapi/storage/gftp.py#L99-L102

This behavior should be changed so it is explicit and doesn't result in unintentional behaviors (e.g. set variables that user would not want to set when using gftp). Additionally we need to allow users to set the gsb url in a clear way from python code level.

  • [ ] Change Golem entrypoint so it allows users to pass gsb url without use of env variables
  • [ ] Change gftp storage so it only sets GSB_URL and RUST_LOG when starting gftp server

lucekdudek avatar Dec 07 '22 13:12 lucekdudek