golang
_content/doc: use mysql.NewConfig() instead of mysql.Config{}
The zero values for mysql.Config is not good for default.
See https://pkg.go.dev/github.com/go-sql-driver/mysql#Config
If a new Config is created instead of being parsed from a DSN string, the NewConfig function should be used, which sets default values.
This PR (HEAD: 99bbecfea8963402ff234a2633e157f0f7914a97) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. After addressing review feedback, remember to publish your drafts!
This tutorial confuses users. https://github.com/go-sql-driver/mysql/issues/1256
Message from Inada Naoki:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. After addressing review feedback, remember to publish your drafts!
Message from Zhen Li:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 1031334dc57e7458b66e82c6dc238bd1e1c317e1) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Inada Naoki:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. After addressing review feedback, remember to publish your drafts!