tools icon indicating copy to clipboard operation
tools copied to clipboard
verified publisher icon golang

txtar: add CRLF handling

Open bsponge opened this issue 2 years ago • 31 comments

  • added handling of CRLF
  • Format will use the same line separator as the one used in the comment or (if the line separator is not found in the comment) in the files
  • Parse will use the same line separator as the one found before the first occurrence of a file marker
  • added a test case with mixed line separators

Fixes golang/go#59264

bsponge avatar Apr 08 '23 21:04 bsponge

This PR (HEAD: b70202e2f207e6723bfa8f7406055aebd4dd104a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 08 '23 21:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 08 '23 21:04 gopherbot

This PR (HEAD: c50c34e581e7e24b816a1962d97ba8da596182f3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 09 '23 12:04 gopherbot

This PR (HEAD: f9b524ef70dc244f3eb63f082fc42d983e8f10d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 09 '23 13:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 10 '23 23:04 gopherbot

This PR (HEAD: 88f0cf9029a71634749f4a27075320251dfa243f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 13 '23 10:04 gopherbot

Message from Bryan Mills:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 13 '23 15:04 gopherbot

This PR (HEAD: 74045de22f157eca30beab46ccbc1434e0e4f0bd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 23 '23 09:04 gopherbot

This PR (HEAD: 22283d2d084e1b47f8d0b4a4b630ae9575e55052) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 23 '23 09:04 gopherbot

This PR (HEAD: 87bb02e4766ccca3d582cd0ee31b70de5cf5b41d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 23 '23 09:04 gopherbot

This PR (HEAD: 8d10046bd635a6a89b61fb289c31516482516c7e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 23 '23 09:04 gopherbot

Message from Jakub Skiba:

Patch Set 11:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 23 '23 09:04 gopherbot

Message from Jakub Skiba:

Patch Set 11:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 02 '23 20:05 gopherbot

Message from [email protected]:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 02 '23 20:05 gopherbot

Message from Subham Sarkar:

Patch Set 11:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 08 '23 18:05 gopherbot

This PR (HEAD: bfc21562a8116b55826a6dd9121695ce8cdddd85) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/483335 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar May 08 '23 19:05 gopherbot

Message from [email protected]:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 08 '23 19:05 gopherbot

Message from Jakub Skiba:

Patch Set 11:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 08 '23 19:05 gopherbot

Message from Jakub Skiba:

Patch Set 12:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 23 '23 21:09 gopherbot

Message from Bryan Mills:

Patch Set 12:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 25 '23 21:09 gopherbot

This PR (HEAD: bfc21562a8116b55826a6dd9121695ce8cdddd85) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Sep 30 '23 13:09 gopherbot

This PR (HEAD: 5b9bb80a85e341458723fde89183552040f2a4c3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Sep 30 '23 14:09 gopherbot

Message from Jakub Skiba:

Patch Set 14:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 30 '23 14:09 gopherbot

Message from Ian Lance Taylor:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 30 '23 16:09 gopherbot

This PR (HEAD: 125ba20a0fcbf22d09bb6f0aac6cdaf3c6ea65f8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Sep 30 '23 16:09 gopherbot

Message from Jakub Skiba:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 30 '23 16:09 gopherbot

This PR (HEAD: e98c1843693695391a918161ba833f67a95d4578) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/483335.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Sep 30 '23 16:09 gopherbot

Message from Ian Lance Taylor:

Patch Set 17: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 01 '23 04:10 gopherbot

Message from Gopher Robot:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 01 '23 04:10 gopherbot

Message from Gopher Robot:

Patch Set 17: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/483335. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 01 '23 04:10 gopherbot