golang
cmd/gotext: fix segfault in extract & rewrite commands
If extract or rewrite are called with no arguments it results in a segmentation fault, since we dereference the out flag that was not defined for these commands.
Fixes golang/go#62697
This PR (HEAD: 96cc7016ea831be73ba80947774c42fe579663d9) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/529255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: b191d33a81a58a9587e5e2b6f351d0bbb9250516) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/529255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to register for Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Mauri de Souza Meneguzzo:
Patch Set 2: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 313ddfad2b9a43d4fbaa875fa4dd3110dcf38083) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/529255.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Mauri de Souza Meneguzzo:
Patch Set 3: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Mauri de Souza Meneguzzo:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 3: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Marcel van Lohuizen:
Patch Set 3: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3: Auto-Submit+1 Code-Review+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-14T16:29:54Z","revision":"4091b21e4c107fed636df3b813ff13d61fb3e02c"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
This CL has failed the run. Reason:
Tryjob golang/try/x_text-gotip-linux-arm64 has failed with summary (view all results):
FAILURE
- go on master (commit c7c578c)
- text on master (change 529255)
Error: failed to run "test golang.org/x/text module": exit status 1
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 4: Auto-Submit+1 Code-Review+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-14T16:47:08Z","revision":"4ae66df4066551e4fae664f7404d2efcbd120b6e"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/529255. After addressing review feedback, remember to publish your drafts!