text icon indicating copy to clipboard operation
text copied to clipboard

x/text: add go modules support (based on ssoroka pr #9)

Open kckrinke opened this issue 3 years ago • 5 comments

Updated version of the original pull request #9.

kckrinke avatar Oct 23 '22 20:10 kckrinke

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 23 '22 20:10 google-cla[bot]

This PR (HEAD: ca408211cff4721da83fc9014e9a4831d840122e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/445035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Oct 23 '22 20:10 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/445035. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '22 20:10 gopherbot

Message from Marcel van Lohuizen:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/445035. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 08 '23 10:06 gopherbot

Please note that the github repository for this PR is being archived and deleted at some point. The new home for things is over at: https://github.com/go-corelibs/x-text

If this PR needs to be resubmitted or otherwise modified, just let me know what to do.

kckrinke avatar Jan 31 '24 18:01 kckrinke