golang
internal/crashmonitor: update the setCrashOutput definition
This PR updates the setCrashOutput definition.
Updates golang/go#67182
This PR (HEAD: ea995a9bebeb82e7e7f2c087bb15ca431586dc42) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/telemetry/+/583278.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alan Donovan:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
Message from Stavros Panakakis:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 5a429a9f3b0ef4b71495b1e10fac2993bdf72004) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/telemetry/+/583278.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Stavros Panakakis:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3: Hold+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 6f5eb73c340be46940728bf6effd5a0370e4c204) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/telemetry/+/583278.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Stavros Panakakis:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 5: Hold+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/583278. After addressing review feedback, remember to publish your drafts!