golang
adds Windows GetAce syscall wrapper
GetAce obtains a pointer to an access control entry (ACE) in an discretionary access control list (DACL), which controls access to an object.
Adds the ACE_HEADER and ACCESS_ALLOWED_ACE structs. Adds GetEntriesFromACL function which returns an array of ACEs from the given ACL if no errors have been encountered.
References:
- https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-ace_header
- https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-access_allowed_ace
- https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-getace
Fixes https://github.com/golang/go/issues/66850
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR (HEAD: c973250fb42a992f613b2124cea32d4f53906efe) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: b911428437f01fe3693735e5490f61f5bb7379a4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Claudiu Belu:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 80961acc5273c4ab58d3ed273c7f76525d0bafc0) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alex Brainman:
Patch Set 4: Commit-Queue+1
(6 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-31T09:26:06Z","revision":"d735e1d438321cc1c168e3bb56f327a3ecb40155"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has failed the run. Reason:
Failed Tryjobs:
- go on release-branch.go1.22 (commit 7456575)
- sys on master (change 578976)
Build or test failure, click here for results.
Additional links for debugging:
- go on master (commit 5bf8c0c)
- sys on master (change 578976)
Error:
shard 3: failed to run test golang.org/x/sys module for goos:"windows" goarch:"arm": exit status 1
failed to run test golang.org/x/sys module for goos:"windows" goarch:"arm64": exit status 1
Additional links for debugging:
- Output for test golang.org/x/sys module for goos:"windows" goarch:"arm" [shard 3]
- Output for test golang.org/x/sys module for goos:"windows" goarch:"arm64" [shard 3]
- Shard 3 encountered a non-build/non-test failure, click here for the shard's build page
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-31T09:37:15Z","revision":"d735e1d438321cc1c168e3bb56f327a3ecb40155"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has failed the run. Reason:
Tryjob golang/try/x_sys-gotip-linux-amd64-misccompile has failed with summary (view all results):
- go on master (commit 5bf8c0c)
- sys on master (change 578976)
Error:
shard 3: failed to run test golang.org/x/sys module for goos:"windows" goarch:"arm": exit status 1
failed to run test golang.org/x/sys module for goos:"windows" goarch:"arm64": exit status 1
Additional links for debugging:
- Output for test golang.org/x/sys module for goos:"windows" goarch:"arm" [shard 3]
- Output for test golang.org/x/sys module for goos:"windows" goarch:"arm64" [shard 3]
- Shard 3 encountered a non-build/non-test failure, click here for the shard's build page
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 9caf768f124a7078a3ad345b6e651d4e17209708) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 9cd77c1fb6f1fd41e7d558433c6708966e2bcc60) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Claudiu Belu:
Patch Set 4:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 6: Commit-Queue+1
(11 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-06-13T10:24:48Z","revision":"145113fd357662d7182ed7e281f035adf3d0041d"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 6: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: d14ca7fb0b8103294fd7c09ee3469ff6f9556508) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Claudiu Belu:
Patch Set 7:
(11 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 8: Commit-Queue+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 8:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-06-23T09:02:37Z","revision":"9cec0cf9f1206c8590de922752ea9eac91222c0c"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 8: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 8:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/578976. After addressing review feedback, remember to publish your drafts!