golang
windows: add GetKeyboardLayout & ToUnicodeEx
These are used along with GetForegroundWindow and GetWindowThreadProcessId to determine the current user layout and translate the base key the user has pressed.
This PR (HEAD: 8dc39ad0eafaa1c32f7f083162a0237d617339d8) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/574755.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Ayman Bagabas:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 1: Commit-Queue+1
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-04-28T07:53:41Z","revision":"737b4a1d29e60a909bcba46a91733836d9388aac"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: b22df7f9e9dd30e88a7eb1ad1fa3925f75955b1d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/574755.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Ayman Bagabas:
Patch Set 1:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: f35ca7f242fde12b8e3422e567f516e2dfb6249f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/574755.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 3aa85da655c62258ad4e687b30377fd00bda0b72) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/574755.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Ayman Bagabas:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Ayman Bagabas:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-16T08:00:45Z","revision":"0ce8ebea88050fa3aebcc7b54998cf0727d813f1"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has failed the run. Reason:
Tryjob golang/try/x_sys-gotip-windows-386 has failed with summary (view all results):
FAILURE
- go on master (commit 722d594)
- sys on master (change 574755)
Error: failed to run "test golang.org/x/sys module": exit status 1
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 4:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: d4d009aecf406c67e24f20f92ea35a731b72c7aa) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/574755.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Ayman Bagabas:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Ayman Bagabas:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 5: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-05-31T08:45:35Z","revision":"d3918b9a7fbab386bebe64e0bfcacfa579f5d9f4"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 5: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
This CL has failed the run. Reason:
Tryjob golang/try/x_sys-gotip-windows-amd64 has failed with summary (view all results):
- go on master (commit 5bf8c0c)
- sys on master (change 574755)
Build or test failure, click here for results.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/574755. After addressing review feedback, remember to publish your drafts!