sys icon indicating copy to clipboard operation
sys copied to clipboard

windows: use cgo.Handle for service object

Open elmeyer opened this issue 2 years ago • 11 comments

This fixes go vet complaints and checkptr crashes when the handler receives an event, e.g. a session change notification.

Fixes golang/go#59687

elmeyer avatar Apr 24 '23 09:04 elmeyer

This PR (HEAD: fe43297c9b9d6bd8a9cc2f640f03a398a5732ad0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/490135 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Quim Muntal:

Patch Set 1: Run-TryBot+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '23 08:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 29 '23 07:04 gopherbot

Message from Quim Muntal:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 29 '23 07:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 29 '23 07:04 gopherbot

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 29 '23 07:04 gopherbot

Message from Bryan Mills:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/490135. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '23 18:05 gopherbot