sync icon indicating copy to clipboard operation
sync copied to clipboard

errorgroup: producing a better failure message for a programmer error

Open shifengbin opened this issue 3 years ago • 5 comments

SetLimit(10) Go(xx) //start a groutine ,g.done be called if task done SetLimit(-1) //<-- g.sem=nil

but g.done is not atomic, if g.sem=nil maybe block the goroutine

shifengbin avatar Jun 18 '22 11:06 shifengbin

This PR (HEAD: 51b70160499559410eebe1a97d750e29086949bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sync/+/413094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jun 18 '22 11:06 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 18 '22 23:06 gopherbot

Message from fengbin shi:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 19 '22 01:06 gopherbot

Message from Bryan Mills:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 21 '22 19:06 gopherbot

Message from fengbin shi:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/413094. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 22 '22 02:06 gopherbot