example icon indicating copy to clipboard operation
example copied to clipboard

fix(template(main.go)): use go:embed

Open danielorbach opened this issue 4 years ago • 4 comments

The new Go1.16 gives us a go:embed directive. This new feature, to my surprise, is not properly represented by the examples in this repository.

I've bumped the version specified by go.mod and used template.ParseFS instead of template.ParseFiles (as portrayed by the package's doc).

danielorbach avatar Apr 25 '21 11:04 danielorbach

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Apr 25 '21 11:04 google-cla[bot]

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

@googlebot I signed it!

danielorbach avatar Apr 25 '21 11:04 danielorbach

This PR (HEAD: ff7b227ef2bf33f6ef6272ff36b317090b93547f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/example/+/313369 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 25 '21 11:04 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/313369. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '21 11:04 gopherbot