commands: fix mismatch in argument error reporting
It was parsing args[0] but reporting an error on args[1],
which might panic and obscure the error.
Also do the initial parsing earlier, to save effort reading the core if we can't proceed.
This PR (HEAD: 30a62f16a6c0e41b74613e8de7e61405df6794af) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/567876.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-29T23:00:57Z","revision":"46c5795f0e5d1a9df113c6772f6a3aeec26502bd"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Bryan Boreham:
Patch Set 1:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/567876. After addressing review feedback, remember to publish your drafts!