debug icon indicating copy to clipboard operation
debug copied to clipboard

internal/gocore: extract type name of method value from its wrapper function name

Open doujiang24 opened this issue 3 years ago • 13 comments

It's a single-entry closure laid out like {pc uintptr, x T}, and the target pc is for wrapper functions named like pkg.T.m-fm or pkg.(*T).m-fm. So, extract the type name pkg.T or *pkg.T from its wrapper function name.

doujiang24 avatar Jul 24 '22 16:07 doujiang24

This PR (HEAD: 3e8d34c45a8a90bb57c6ea24fb0adeff216e55ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419179 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 24 '22 16:07 gopherbot

This PR (HEAD: a68e8c08051d06a9e1336d34cc0537859532aefc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419179 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 25 '22 10:07 gopherbot

Message from Keith Randall:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 30 '22 00:07 gopherbot

This PR (HEAD: 06c4fafc0dcb54bed351ff2f208238d4a43decad) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419179 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 30 '22 09:07 gopherbot

Message from DeJiang Zhu:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 30 '22 09:07 gopherbot

Message from Keith Randall:

Patch Set 3: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 31 '22 18:07 gopherbot

Message from Gopher Robot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 31 '22 18:07 gopherbot

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 31 '22 18:07 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 01 '22 16:08 gopherbot

Message from DeJiang Zhu:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 02 '22 01:08 gopherbot

Message from Hyang-Ah Hana Kim:

Patch Set 5: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 03 '22 15:08 gopherbot

Message from Keith Randall:

Patch Set 5: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 04 '22 18:08 gopherbot

Message from DeJiang Zhu:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/419179. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 10 '22 01:08 gopherbot

This PR is being closed because golang.org/cl/419179 has been merged.

gopherbot avatar Aug 15 '22 17:08 gopherbot