debug internal/gocore: disambiguate type candidates by object size

Match the object size when there are multiple candidates for the pointers to structs with the same struct name and same package name. Also, allow - in the package path.

Jul 24 '22 16:07 doujiang24

This PR (HEAD: 0f81fd84afb204c1faefe49381db8117c75cc706) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Jul 24 '22 16:07 gopherbot

Message from Keith Randall:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Jul 29 '22 23:07 gopherbot

This PR (HEAD: 0e1d76709f932931251790e12fb911539830d83f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Jul 30 '22 15:07 gopherbot

Message from DeJiang Zhu:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Jul 30 '22 15:07 gopherbot

Message from Keith Randall:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Jul 31 '22 19:07 gopherbot

This PR (HEAD: d4ee246b26473d413b6bb895da12fd1c067eec94) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Aug 01 '22 15:08 gopherbot

Message from DeJiang Zhu:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 01 '22 15:08 gopherbot

Message from Keith Randall:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 01 '22 17:08 gopherbot

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 01 '22 17:08 gopherbot

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 01 '22 17:08 gopherbot

This PR (HEAD: 44eaf0c72934a45fd6b0735ff07d127e91c5dcda) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Aug 02 '22 09:08 gopherbot

Message from DeJiang Zhu:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 02 '22 09:08 gopherbot

Message from Keith Randall:

Patch Set 4: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 02 '22 17:08 gopherbot

Message from Keith Randall:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 02 '22 17:08 gopherbot

This PR (HEAD: 3cd191c6227e878f9f6f14ab832cde68f13799ff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Aug 03 '22 09:08 gopherbot

Message from DeJiang Zhu:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 03 '22 09:08 gopherbot

Message from Keith Randall:

Patch Set 5: Run-TryBot+1 Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 03 '22 16:08 gopherbot

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 03 '22 16:08 gopherbot

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 03 '22 16:08 gopherbot

This PR (HEAD: e25a8028f1b16a8ae80ed0c2779f8b99f4946aff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Aug 04 '22 01:08 gopherbot

Message from DeJiang Zhu:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 04 '22 01:08 gopherbot

Message from Keith Randall:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 04 '22 16:08 gopherbot

Message from Matthew Dempsky:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 04 '22 18:08 gopherbot

Message from DeJiang Zhu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 05 '22 09:08 gopherbot

Message from DeJiang Zhu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 10 '22 01:08 gopherbot

Message from Keith Randall:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 15 '22 17:08 gopherbot

Message from Than McIntosh:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 15 '22 17:08 gopherbot

Message from David Chase:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 15 '22 17:08 gopherbot

This PR (HEAD: 5b48ab1a6716dfc805f13306fa36f4fc1c018583) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419176 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Aug 16 '22 02:08 gopherbot

Message from DeJiang Zhu:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419176. After addressing review feedback, remember to publish your drafts!

Aug 16 '22 02:08 gopherbot