Fix. Return 404 when artefacts are requested for the non-existing repository.
Return 404 when artefacts are requested for the non-existing repository.
A small addition checks if a repository exists before getting the artefacts list.
Issue being fixed
Fixes #17443
Please indicate you've done the following:
- [x] Well Written Title and Summary of the PR
- [x] Label the PR as needed. release-note/enhancement
- [x] Accepted the DCO. Commits without the DCO will delay acceptance.
- [x] Made sure tests are passing and test coverage is added if needed.
- [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
Project coverage is 66.22%. Comparing base (
c8c11b4) to head (e3beda9). Report is 247 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #17618 +/- ##
===========================================
+ Coverage 45.36% 66.22% +20.85%
===========================================
Files 244 1045 +801
Lines 13333 113508 +100175
Branches 2719 2845 +126
===========================================
+ Hits 6049 75173 +69124
- Misses 6983 34223 +27240
- Partials 301 4112 +3811
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 66.22% <0.00%> (+20.85%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| src/server/v2.0/handler/artifact.go | 8.52% <0.00%> (ø) |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
@tpoxa - thanks for contributing; can someone take a look at this @chlins @ywk253100 @MinerYang @stonezdj thanks!
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
Hi all @goharbor/all-maintainers , can someone take a look at this also @tpoxa - thanks for contributing; can someone take a look at this @chlins @ywk253100 @MinerYang @stonezdj thanks! it's a second time stale!
@tpoxa can you please fix the UT failure as well?
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
@tpoxa hey can you fix the mentioned by @wy65701436 thank you!
also DCO needs fixing
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.