storage icon indicating copy to clipboard operation
storage copied to clipboard

New Storage Driver: Cassandra

Open aliziyacevik opened this issue 2 years ago • 28 comments

Hey guys, this is the continuum of #852 which I accidentally closed and messed up so I opened this.

Thanks for the reviews.

aliziyacevik avatar Jun 18 '23 09:06 aliziyacevik

Hi @gaby, since #852 is closed I opened this.

aliziyacevik avatar Jun 18 '23 10:06 aliziyacevik

@aliziyacevik Can you update the gosec.yml inside github to exclude cassandra for the root test, and include cassandra at the botton of the file

gaby avatar Jun 18 '23 12:06 gaby

@aliziyacevik This may be related, not sure yet

https://github.com/gocql/gocql/issues/997

gaby avatar Jun 18 '23 13:06 gaby

no problem @gaby, I will work on that to find a solution. thanks for your help.

aliziyacevik avatar Jun 18 '23 13:06 aliziyacevik

hi @gaby, right now I'm assuming the GitHub ci/cd doesn't wait for Cassandra to be available on port 9042, that's why it can't pass the test. what do you think ?

aliziyacevik avatar Jun 18 '23 15:06 aliziyacevik

hi @gaby, right now I'm assuming the GitHub ci/cd doesn't wait for Cassandra to be available on port 9042, that's why it can't pass the test. what do you think ?

Let me do some research and i will reply back here

gaby avatar Jun 18 '23 16:06 gaby

@aliziyacevik I dont think there's a way to run it in gh actions. Setting address to 0.0.0.0 causes container to fail. Cassandra doesnt allow using that

gaby avatar Jun 19 '23 04:06 gaby

@gaby okay, let me also look for a solution

aliziyacevik avatar Jun 19 '23 20:06 aliziyacevik

Hi @aliziyacevik can you just remove the service definition for cassandra and add a new step that calls docker commands directly like I did for couchbase in here and then you can add sleep command after starting cassandra container 👍

mstrYoda avatar Jun 28 '23 12:06 mstrYoda

sure @mstrYoda, the first moment I get on my laptop.

aliziyacevik avatar Jun 29 '23 05:06 aliziyacevik

I will try @mstrYoda suggests now.

aliziyacevik avatar Jun 29 '23 11:06 aliziyacevik

@aliziyacevik Are you able to connect to a local cassandra instance in your dev env?

gaby avatar Jul 01 '23 15:07 gaby

Yes @gaby. I opened both in Docker and in my local. They're both working.

aliziyacevik avatar Jul 01 '23 16:07 aliziyacevik

Yes @gaby. I opened both in Docker and in my local. They're both working.

I'm not sure how cassandra work, but can you run a container and only using this Storage driver connect and set/get data? Or did you need to setup CQL files, etc before trying to use the storage driver?

gaby avatar Jul 01 '23 17:07 gaby

@aliziyacevik if you would like to, let's get together and make a quick pair on Go Türkiye/Fiber discord channel?

mstrYoda avatar Jul 01 '23 18:07 mstrYoda

Sure @mstrYoda.

aliziyacevik avatar Jul 02 '23 08:07 aliziyacevik

I didnt create any etc or CQL file because its not necessary (atleast I thoght) ı will check it out again. @gaby

aliziyacevik avatar Jul 02 '23 08:07 aliziyacevik

@aliziyacevik can you refresh your branch with the master

ReneWerner87 avatar Jul 17 '23 12:07 ReneWerner87

@mstrYoda when can we make a pair ?

aliziyacevik avatar Jul 18 '23 08:07 aliziyacevik

@mstrYoda when can we make a pair ?

Just ping me on discord 👍

mstrYoda avatar Jul 18 '23 13:07 mstrYoda

Sorry for the latency guys. I really cant find time to investigate this. Hopefully really soon, I will look at this with @mstrYoda . Just wanted to let you @gaby @ReneWerner87 know. Thanks.

aliziyacevik avatar Jul 21 '23 13:07 aliziyacevik

@aliziyacevik Can you fix the merge conflicts with the gosec.yml ?

gaby avatar Jul 30 '23 01:07 gaby

@gaby sure.

@mstrYoda abi naptın bakıyor muyuz buna beraber yayında yoksa fixleyeyim mi ben şimdi ? başka şeyler de yaparız yayında. tabi hala davetliysem :)

aliziyacevik avatar Oct 02 '23 10:10 aliziyacevik

@gaby sure.

@mstrYoda abi naptın bakıyor muyuz buna beraber yayında yoksa fixleyeyim mi ben şimdi ? başka şeyler de yaparız yayında. tabi hala davetliysem :)

I am writing to you on discord again, lets meet 👍

mstrYoda avatar Oct 02 '23 10:10 mstrYoda

@mstrYoda any progress ?

ReneWerner87 avatar Nov 16 '23 07:11 ReneWerner87

@aliziyacevik @mstrYoda friendly ping, thx for the effort

can you update this PR and also check the last hints

ReneWerner87 avatar Mar 24 '24 19:03 ReneWerner87

@aliziyacevik @mstrYoda friendly ping

ReneWerner87 avatar May 01 '24 15:05 ReneWerner87

@aliziyacevik @mstrYoda friendly ping

hey @ReneWerner87, Thanks for the reminder and sorry for the such a long delay :(. I will resolve the conflicts.

aliziyacevik avatar May 02 '24 12:05 aliziyacevik