godot-cpp-template icon indicating copy to clipboard operation
godot-cpp-template copied to clipboard

Use special double entries in gdextension

Open fire opened this issue 1 year ago • 4 comments

Godot version

https://github.com/V-Sekai/godot/commit/35b10e36d919247cf9e7c06892bf1c38ef027b0b

godot-cpp version

https://github.com/godotengine/godot-cpp/tree/fbbf9ec4efd8f1055d00edb8d926eef8ba4c2cce

System information

Macos

Issue description

Godot added a feature for the particular naming of the double extension libraries.

https://github.com/libriscv/godot-sandbox/blob/main/bin/addons/godot_sandbox/bin/godot-riscv.gdextension

godot-cpp-template does not use it. https://github.com/godotengine/godot-cpp-template/blob/main/demo/bin/example.gdextension

godot-cpp-template should use the special syntax. Note that the order of the double vs single matters.

fire avatar Nov 07 '24 05:11 fire

~~This is half addressed in #55, through the use of env["suffix"] in the naming scheme, which is defined here and (i think) intended for this purpose. The PR does not currently add new entries to the .gdextension file.~~

Edit: actually, godot-cpp-template already uses env["suffix"], which includes .double when relevant. We just need to add separate entries in the .gdextension to address your issue.

Still, i want to note that the naming scheme implies a few more missing combinations, such as .nothreads.

Ivorforce avatar Nov 07 '24 09:11 Ivorforce

I downloaded image from https://github.com/godotengine/godot-cpp-template/actions/runs/11691017198/job/32557244884 doubles build.

godot-cpp-template.zip and it does not build doubles libEXTENSION-NAME.macos.template_debug, I suspect it is overwriting.

Secondly libEXTENSION-NAME.macos.template_debug is missing env["arch"]

fire avatar Nov 07 '24 16:11 fire

Secondly libEXTENSION-NAME.macos.template_debug is missing env["arch"]

That one is actually fixed by #55.

Ivorforce avatar Nov 08 '24 12:11 Ivorforce

With #77 the double binaries for macOS and iOS are now present but they're still not referenced by the .gdextension file.

unvermuthet avatar Feb 20 '25 17:02 unvermuthet

I forgot about this issue - the .gdextension file has had double entries since https://github.com/godotengine/godot-cpp-template/pull/85 was merged.

Ivorforce avatar Jun 19 '25 23:06 Ivorforce