godot-cpp-template icon indicating copy to clipboard operation
godot-cpp-template copied to clipboard

Add CMake file

Open enetheru opened this issue 1 year ago • 5 comments

Adds a CMakeLists that builds against 4.4

enetheru avatar Oct 23 '24 06:10 enetheru

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:

git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git
git submodule set-branch -b modernise godot-cpp
git submodule sync
git submodule update --init --recursive --remote

Edit: The above no longer applies, this pr is now synchronised to 4.4

enetheru avatar Nov 06 '24 01:11 enetheru

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:


git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git

git submodule set-branch -b modernise godot-cpp

git submodule sync

git submodule update --init --recursive --remote

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

paddy-exe avatar Mar 04 '25 08:03 paddy-exe

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

I think I updated the submodule to 4.4 in this PR so I could test it. I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

enetheru avatar Mar 04 '25 13:03 enetheru

I think I updated the submodule to 4.4 in this PR so I could test it.

I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

Sounds good as well👍🏻 in that case we can wait until your PR is in a mergeable state

paddy-exe avatar Mar 04 '25 14:03 paddy-exe

I've updated godot-cpp submodule in this PR for the latest cherry picks in 4.4 as they are highly desired. I minimised the solution too, rather than try to educate or add useful things, The only thing I have in here that's extra is that cmake will perform the git submodule update --init if the godot-cpp tree isnt populated. I'm still waiting on approval of the CI for godot-cpp. But this is basically ready, if you like I can submit CI changes in a different PR.

enetheru avatar Mar 20 '25 03:03 enetheru

Hey @enetheru sorry for taking so long to respond to your last message. Can this PR be merged if I understand you correctly?

paddy-exe avatar May 29 '25 00:05 paddy-exe

Hey @enetheru sorry for taking so long to respond to your last message. Can this PR be merged if I understand you correctly?

yeah

enetheru avatar May 29 '25 02:05 enetheru

Alright merged. Thank you @enetheru!

paddy-exe avatar May 29 '25 13:05 paddy-exe