coblocks icon indicating copy to clipboard operation
coblocks copied to clipboard

ISBAT easily debug the Row block and Typography controls

Open AnthonyLedesma opened this issue 5 years ago • 0 comments

Is your feature request related to a problem? Please describe.

Typography controls and Row block have an integrated API stemming from shared use of a utility function called applyStyles. This function is responsible for setting column width within the editor while using the Row block. Because of the nature of the current architecture, it makes understanding the source of bugs both difficult to understand and difficult to find. For the sake of future expectations of maintenance, I propose that a new control be set up for the Row block which specifically handles the setting of column width.

A recent fix for both the Row block and the Typography controls can be found here: https://github.com/godaddy-wordpress/coblocks/pull/1711

Describe the solution you'd like

Suggest moving the logic to apply wrapper styles for the Column block within the Row block directory in CoBlocks. Both for organizational reasons as well as readability and understandability.

Describe alternatives you've considered

Keep the way it is with the expectation of eventual deprecation for core features.

AnthonyLedesma avatar Oct 02 '20 21:10 AnthonyLedesma