authentik icon indicating copy to clipboard operation
authentik copied to clipboard

sources: add spnego

Open rissson opened this issue 2 years ago • 5 comments

Details

Add a SPNEGO source. Allows login using an existing Kerberos identity.

TODO:

  • [x] update CI & docker image to add required system libraries for GSSAPI
  • [x] update CI to install required tools to run SPNEGO tests
  • [x] documentation

Checklist

  • [x] Local tests pass (ak test authentik/)
  • [x] The code has been formatted (make lint-fix)

If an API change has been made

  • [x] The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • [ ] The code has been formatted (make web)
  • [x] The translation files have been updated (make i18n-extract)

If applicable

  • [x] The documentation has been updated
  • [x] The documentation has been formatted (make website)

cc. @Mareo

rissson avatar Jan 29 '24 14:01 rissson

Deploy Preview for authentik-storybook ready!

Name Link
Latest commit 8d017178bde30ea725b9349a10b5c4c070befd01
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65ba7b84dd89420008190867
Deploy Preview https://deploy-preview-8344--authentik-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 29 '24 14:01 netlify[bot]

Deploy Preview for authentik ready!

Name Link
Latest commit f32bec84801afb64d012a0e45e891845ad5585a7
Latest deploy log https://app.netlify.com/sites/authentik/deploys/65b7cdb9d7b1330008e4122e
Deploy Preview https://deploy-preview-8344--authentik.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 29 '24 14:01 netlify[bot]

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

github-actions[bot] avatar Jan 29 '24 14:01 github-actions[bot]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (dca8c83) 92.29% compared to head (8d01717) 90.75%. Report is 26 commits behind head on main.

Files Patch % Lines
authentik/sources/spnego/views.py 82.71% 14 Missing :warning:
authentik/sources/spnego/models.py 93.33% 5 Missing :warning:
authentik/sources/spnego/tests.py 96.55% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8344      +/-   ##
==========================================
- Coverage   92.29%   90.75%   -1.55%     
==========================================
  Files         626      632       +6     
  Lines       30948    31250     +302     
==========================================
- Hits        28565    28362     -203     
- Misses       2383     2888     +505     
Flag Coverage Δ
e2e 49.44% <42.51%> (-1.19%) :arrow_down:
integration ?
unit 89.54% <91.73%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 15:01 codecov[bot]

Actually I have an even better implementation in progress that supports user sync and password writeback. It'll be an ok solution to use until we have a proper kerberos provider setup.

rissson avatar Jan 29 '24 21:01 rissson

Closing in favor of https://github.com/goauthentik/authentik/pull/10815

rissson avatar Aug 07 '24 22:08 rissson