mysql icon indicating copy to clipboard operation
mysql copied to clipboard

Can support mysql compress protocol?

Open zhanghaiyang9999 opened this issue 4 years ago • 6 comments

Issue description

Tell us what should happen and what happens instead I saw the codes:

// Compression case "compress": return errors.New("compression not implemented yet") it means can't support mysql compression protocl?

Example code

If possible, please enter some example code here to reproduce the issue.

Error log

If you have an error log, please paste it here.

Configuration

Driver version (or git SHA):

Go version: run go version in your console

Server version: E.g. MySQL 5.6, MariaDB 10.0.20

Server OS: E.g. Debian 8.1 (Jessie), Windows 10

zhanghaiyang9999 avatar Nov 10 '21 11:11 zhanghaiyang9999

Duplicate of #24 and #649.

methane avatar Nov 12 '21 01:11 methane

Can merge these commits regarding compression into master branch? the compression is very important in some cases.

zhanghaiyang9999 avatar Nov 12 '21 02:11 zhanghaiyang9999

Would you please refer this link?

https://pkg.go.dev/github.com/Pooh-Mucho/go-mysql-stdzlib#section-readme

can it solve the compression issue? @methane

zhanghaiyang9999 avatar Nov 15 '21 07:11 zhanghaiyang9999

I don't understand what do you mean. What "refer" means? What "solve the compression issue" means??

methane avatar Nov 15 '21 08:11 methane

I meant it seems that the link https://pkg.go.dev/github.com/Pooh-Mucho/go-mysql-stdzlib#section-readme provides the way to support compression.

I want to know what the relationship between go-mysql-stdzlib and go-sql-driver /mysql

zhanghaiyang9999 avatar Nov 15 '21 09:11 zhanghaiyang9999

I don't know. Why do you ask it here, instead of the owner of the repo?

At least, the author omits all git history. That is not good in two points: project quality and respect to the original author. So I won't recommend the project at all.

methane avatar Nov 16 '21 03:11 methane