go-sql-driver
Misc fixes and refactoring
Description
This PR includes a collection of different kinds of fixes (see commit messages below) to issues found with the help of several linters, ranging from missing error checks, to resource leaks because of unclosed rows / statements (luckily only in tests), a benchmark calling a wrong function, typos, shadowing issues and scope issues to bad coding style / formatting issues.
This PR also serves as a preparation for adding better linters to our CI pipeline.
Checklist
- [x] Code compiles correctly
- [x] All tests passing
LGTM.
But 0ea749dd seems too strict to me. I usually use this variable hiding. Which linter do you want to use?
According to the documentation comment of converter.ConvertValue(),
ConvertValue mirrors the reference/default converter in database/sql/driver with one exception
I think alignment with driver.defaultConverter.ConvertValue() is more important than coding style consistency here, so fixes in that method seems overdoing to me.
If these changes are merged, it will be difficult to check what is changed from reference implementation.
@julienschmidt It would be better to resubmit each lint error fix as separate MR. It would be easier to review and accept at least some of them.
