cpy3 icon indicating copy to clipboard operation
cpy3 copied to clipboard
verified publisher icon go-python

review tests on Windows

Open christian-korneck opened this issue 3 years ago • 2 comments

some tests aren't working on Windows, probably never have.

christian-korneck avatar Jun 03 '22 23:06 christian-korneck

Hi @christian-korneck,

I found 3 issues when running test ong windows. But I'm not sure whether it's a environment or os specific for the first two issues.

  1. getvalue method can't be found on windows https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/high_level_layer_test.go#L19

  2. I got a PyExc_KeyboardInterrupt which don't match PyExc_TypeError. https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/errors_test.go#L250

  3. File path is diffrent. This issue can be fixed by trim "/" https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/module_test.go#L110

RolandMa1986 avatar Aug 05 '22 01:08 RolandMa1986

thanks, would love to see PRs to fix these.

christian-korneck avatar Aug 05 '22 11:08 christian-korneck