syncs
syncs copied to clipboard
go-pkgz
Draft: Add support of discard with treshold option, remake the solution usin…
…g channels
The change is inspired by the comment https://github.com/go-pkgz/syncs/issues/5#issuecomment-1504123418. The solution relies on channels as the main synchronization primitive, instead of semaphore.
Pull Request Test Coverage Report for Build 10548914574
Details
- 70 of 76 (92.11%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-2.4%) to 96.46%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| group_options.go | 7 | 9 | 77.78% |
| sizedgroup.go | 63 | 67 | 94.03% |
| <!-- | Total: | 70 | 76 |
| Totals | |
|---|---|
| Change from base Build 6286685592: | -2.4% |
| Covered Lines: | 218 |
| Relevant Lines: | 226 |
💛 - Coveralls
Added few test cases that should fix the coverage, slightly improved the API. Pls, run the job