session icon indicating copy to clipboard operation
session copied to clipboard

Destory => Destroy?

Open lol768 opened this issue 9 years ago • 4 comments

Destory isn't a word, but I imagine this will break backwards compatibility?

https://github.com/go-macaron/session/blob/master/session.go#L57

lol768 avatar Aug 21 '16 17:08 lol768

Good point...

unknwon avatar Aug 23 '16 16:08 unknwon

How about fixing this? I know this is exported, but It is always confuse reading Destory for a Destroy action. It could be fixed in a major release.

mjtrangoni avatar Apr 13 '18 18:04 mjtrangoni

@mjtrangoni yes, that's why the issue is still not fixed by no major release is planned anytime soon...

unknwon avatar Apr 16 '18 21:04 unknwon

Using Go Modules and push out a v2 release seems ideal.

unknwon avatar Jul 21 '19 23:07 unknwon