go-billy icon indicating copy to clipboard operation
go-billy copied to clipboard

Update embedfs implementation

Open this-kirke opened this issue 7 months ago • 3 comments

Fixes to embedfs implementation:

  • Fix path normalization to support billy's absolute path convention ("/")
  • Implement missing Lstat method (was returning ErrNotSupported)
  • Add proper embed.FS to billy path conversion throughout all methods

Additional test coverage:

  • Add dedicated test files for different functionality areas
  • Test File interface methods including ReadAt, Close, Lock/Unlock
  • Add path normalization and edge case testing
  • Test empty file handling and boundary conditions
  • Verify proper error handling for read-only operations

Test infrastructure:

  • Create embedfs_testdata package for reusable test data
  • Resolve import cycles with clean provider pattern
  • Add test data including nested directories and various file types
  • Organize tests by functionality (fs, dir, file operations)

The embedfs implementation now provides billy.Filesystem compliance for read-only embedded filesystems.

this-kirke avatar Jul 23 '25 03:07 this-kirke

Hi Paulo! Thank you for the review. I've updated with requested changes; all tests pass.

this-kirke avatar Jul 27 '25 03:07 this-kirke

Thank you for the detailed review! I agree on all points. I think everything should be resolved now; please let me know if there's anything else you notice. We can squash on complete.

this-kirke avatar Jul 27 '25 21:07 this-kirke

Quite a few suggestions I made were marked as resolved without them being acted upon. I added some of them on the last commit, but don't really have the time atm to review everything that was incorrectly marked as resolved.

pjbgf avatar Oct 15 '25 21:10 pjbgf