render icon indicating copy to clipboard operation
render copied to clipboard

Added custom json serializer support

Open josearomeroj opened this issue 3 years ago • 3 comments

Implemented custom serializer for json: https://github.com/go-chi/render/issues/36

josearomeroj avatar Jun 26 '22 11:06 josearomeroj

[at]Maintainers would be nice if you could comment if this PR has a chance of being merged. My use-case is just to configure the json-decoder (just setting DisallowUnknownFields() to try to detect typos in requests) but right now even such a small adjustment is not possible.

Oh and @josearomeroj would you still work on this PR if the Maintainers want any changes? (otherwise I'd be willing to adopt this PR by cloning and create a new PR)

atticus-sullivan avatar Apr 06 '23 19:04 atticus-sullivan

Hi @atticus-sullivan, thank you for your feedback. I have no problem to continue working in this but looks like maintainers are inactive.

josearomeroj avatar Apr 07 '23 14:04 josearomeroj

Oh nice, that's already the first step. Wasn't sure since almost a whole year passed since you opened this issue. Well looking at the commits the maintainers are a bit inactive, but from time to time there is work. Not sure if there is a better way of contacting them than writing in comments in the PR. Maybe we can Ping @pkieltyka seems to be the only one in the go-chi organization. According to this comment, this package is still maintained (but I always try not to put too much pressure on maintainers of open source projects as this is free-time and it should feel like it)

Especially in this case not having this feature is a bit sad as looking at other PRs (#34 #33 #39 , I think even #11 would be possible to configure) this feature really helps a lot.

atticus-sullivan avatar Apr 07 '23 20:04 atticus-sullivan