Suggestion
Hi @gmarm, First thing, thanks for building this library, it's great and exactly what I was needed!
I'd like to suggest few things to change, to make the library even better:
-
Make settings
optionsmore easier to understand In the beginning I thought there is no way to change it, but now I find out that I can change it viaoptionsproperty, it's not the most understandable way and I couldn't find any examples in theREADME.mdor in the Example project, I think you should do something about it. -
Remove
layer.masksToBounds = truefrom line 310 whenindicatorViewInsetis negative When theindicatorViewInsetis negative you should get nice effect like this:
But instead of that the indicatorViewBackgroundis cutting of when it's passing theBetterSegmentedControlparent view because of this line. I don't see any problem after comment it out so it's just unnecessary.
I'v created pull request for this: #87
Thanks, Ido.
- has been addressed by https://github.com/gmarm/BetterSegmentedControl/pull/78
- I will be having a look at this and your PR since the implementation changed a bit there.