BetterSegmentedControl icon indicating copy to clipboard operation
BetterSegmentedControl copied to clipboard

Suggestion

Open Idomo opened this issue 7 years ago • 1 comments

Hi @gmarm, First thing, thanks for building this library, it's great and exactly what I was needed!

I'd like to suggest few things to change, to make the library even better:

  1. Make settings options more easier to understand In the beginning I thought there is no way to change it, but now I find out that I can change it via options property, it's not the most understandable way and I couldn't find any examples in the README.md or in the Example project, I think you should do something about it.

  2. Remove layer.masksToBounds = true from line 310 when indicatorViewInset is negative When the indicatorViewInset is negative you should get nice effect like this: img_ea39e9e44b0f-1 But instead of that the indicatorViewBackground is cutting of when it's passing the BetterSegmentedControl parent view because of this line. I don't see any problem after comment it out so it's just unnecessary.

I'v created pull request for this: #87

Thanks, Ido.

Idomo avatar Jul 10 '18 19:07 Idomo

  1. has been addressed by https://github.com/gmarm/BetterSegmentedControl/pull/78
  2. I will be having a look at this and your PR since the implementation changed a bit there.

gmarm avatar Jul 22 '18 15:07 gmarm