gluster
Rebalance missing validation and code refactor
Remaining :
- CLI
- E2E
- TODOs.
Will update the PR with the remaining sections.
@rishubhjain please add a TODO for UNDO functions in txn steps for rebalance start and stop.
On Fri, 20 Jul 2018 at 19:32, Rishubh Jain [email protected] wrote:
@rishubhjain commented on this pull request.
In plugins/rebalance/rest.go https://github.com/gluster/glusterd2/pull/986#discussion_r204054533:
@@ -44,14 +44,18 @@ func rebalanceStartHandler(w http.ResponseWriter, r *http.Request) { return }
- rebalinfo := createRebalanceInfo(volname, &req)
- if rebalinfo == nil {
logger.WithError(err).Error("failed to create Rebalance info")IMO : Its easier to debug if the resource name is provided with error/debug message
What’s the resource name represent here? Isn’t that supposed to be volume name?
—
You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gluster/glusterd2/pull/986#discussion_r204054533, or mute the thread https://github.com/notifications/unsubscribe-auth/AGp7mEcHkbYQhWDT1HB4blpGsPr9hepRks5uIeLvgaJpZM4VJwat .
--
- Atin (atinm)
