gluster-prometheus icon indicating copy to clipboard operation
gluster-prometheus copied to clipboard

Unit of latency metrics

Open random-user-00 opened this issue 5 years ago • 2 comments

What is the exact unit for latency metrics? It is not in documentation or Metrics type description. e.g. gluster_volume_profile_fop_avg_latency gluster_volume_profile_fop_max_latency

I assume these values are in milliseconds, but having some description in metric description would be useful.

random-user-00 avatar Jul 30 '20 18:07 random-user-00

@random-user-00 enable collectors.gluster_volume_profile contain gluster_volume_profile_fop_avg_latency and gluster_volume_profile_fop_max_latency

[collectors.gluster_volume_profile]
name = "gluster_volume_profile"
sync-interval = 5
disabled = fals

you can look at line 141 of https://github.com/gluster/gluster-prometheus/blob/ec6f41bc9500a5c1ce718fa5b7466ee5552417d5/gluster-exporter/metric_volume.go e

.....
	glusterVolumeProfileFopAvgLatency = registerExportedGaugeVec(Metric{
		Namespace: "gluster",
		Name:      "volume_profile_fop_avg_latency",
		Help:      "Cumulative FOP avergae latency",
		LongHelp:  "",
		Labels:    volumeProfileFopInfoLabels,
	}, &volumeProfileGaugeVecs)

....
func init() {
	registerMetric("gluster_volume_heal", healCounts)
	registerMetric("gluster_volume_profile", profileInfo)
}

limiao2008 avatar Dec 11 '20 07:12 limiao2008

Others need to be noted see it https://github.com/gluster/gluster-prometheus/issues/147#issuecomment-743010344

limiao2008 avatar Dec 11 '20 07:12 limiao2008