gluster-containers icon indicating copy to clipboard operation
gluster-containers copied to clipboard

Fedora: be more efficient for detecting brick mux setting

Open obnoxxx opened this issue 6 years ago • 4 comments

Previously, we were grep-ing through the output of gluster volume info for the value of the cluster.brick-multiplex setting. But it is highly inefficient to use gluster volume list to obtain a global setting. With many volumes, this can take unnecessarily long. Furthermore, since this is invoked right after the start of glusterd, glusterd may not be done initializing.

This patch changes the retrieval of the brick multiplex setting to use the command gluster volume get all cluster.brick-multiplex which is exactly made for this purpose and won't get the whole list of volumes.

obnoxxx avatar Feb 20 '19 18:02 obnoxxx

CAVEAT: needs to be tested

obnoxxx avatar Feb 20 '19 18:02 obnoxxx

@atinmu this should roughly be what we discussed on chat today. Please take a look!

obnoxxx avatar Feb 20 '19 18:02 obnoxxx

@obnoxxx @atinmu one other thought here. Do we need to fetch current setting at all ? rather based on the user request go ahead and try it. Thoughts ?

humblec avatar Feb 21 '19 11:02 humblec

@obnoxxx ping :)

humblec avatar Apr 30 '19 11:04 humblec