glinscott
Games uploaded contain illegal FENs
I just noticed that the FENs in the games uploaded do not contain plies and move information. They are thus non compliant and cannot, e.g., be imported in python-chess.
The reason is of course that the FENs in 2moves_v1.pgn are themselves illegal. What do we do?
The solution of the problem is quite simple, we have to replace the 2moves_v1.pgn with one containing the information. I was wondering if we want to fix this, in which case we have to restart the old activities about porting everything from @mcostalba fishcooking to this repository. Any thoughts?
Already tested with https://github.com/glinscott/fishtest/pull/240. IMO better to use a different/new repository for opening books and cutechess-cli binaries.
You mean a different from @mcostalba fishcooking or a different from this one? I just created a branch https://github.com/Stefano80/fishtest/tree/openingBooks_v2 where I added the opening books and the cutechess binaries and libs. Could you give a look and check whether this is all what we need?
With #240 the setup of the dev-server and test workers was very slow. To avoid leftovers I test new patches deleting the fishtest folder and cloning the official fishtest repository. I don't know git lfs, a new github repository should be sufficient.
Ok. My proposal would be to have an official-stockfish/resources repositories for this kind of stuff. Maybe @snicolet can give his opinion.
Yes a separate resources repo is a good idea for the bigger non source items.
Git lfs is interesting but adding this to the client is probably non trivial/overkill, unless it is easy to access the lfs items with a simple http download.
