glide icon indicating copy to clipboard operation
glide copied to clipboard

Add package.json "type" field

Open julienchazal opened this issue 3 years ago • 2 comments

This change makes Glide compatible with Node > 15

Within a package, the package.json "type" field defines how Node.js should interpret .js files. If a package.json file does not have a "type" field, .js files are treated as CommonJS.

A package.json "type" value of "module" tells Node.js to interpret .js files within that package as using ES module syntax.

julienchazal avatar Sep 07 '22 08:09 julienchazal

see #620

julienchazal avatar Sep 07 '22 08:09 julienchazal

Looks like the build is failing as adding this property requires to use of ESM export/import module syntax. Probably jest.config.js just need to use export default instead of module.exports =

jedrzejchalubek avatar Sep 12 '22 21:09 jedrzejchalubek

thanks @jedrzejchalubek 👍

julienchazal avatar Sep 22 '22 14:09 julienchazal