glide-data-grid icon indicating copy to clipboard operation
glide-data-grid copied to clipboard

Row grouping modules missing in package

Open theiliad opened this issue 1 year ago • 5 comments

I've noticed that a lot of modules related to row-grouping don't seem to be included in 6.0.3 release, not sure if previous releases did in fact include those

For instance these files

image

and

image

are missing from final build https://unpkg.com/browse/@glideapps/[email protected]/src/data-editor/

I'm also seeing type warnings suggesting that this feature might not actually be in the package image

Also I'm not able to see any results after pulling all those modules into my local codebase, and adding rowGrouping to my grid

Is this in fact an issue?

theiliad avatar May 31 '24 16:05 theiliad

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

citizensas avatar May 31 '24 18:05 citizensas

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

I see, so not stable yet?

theiliad avatar May 31 '24 19:05 theiliad

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

snowy-owll avatar Jun 15 '24 14:06 snowy-owll

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours const item = data[isGroupHeader ? originalIndex[1] : row];

mirus-ua avatar Jun 18 '24 12:06 mirus-ua

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours const item = data[isGroupHeader ? originalIndex[1] : row];

@mirus-ua Yes, I know about this. It helps with collapsing rows, but it returns a little wrong index. Even their example doesn't show all the data. It should display 1000 rows, but the last row index is 995. So, every group "eats" one row.

snowy-owll avatar Jun 18 '24 18:06 snowy-owll

Closing this since its included in the alpha release and we also recently merged some fixes: https://github.com/glideapps/glide-data-grid/pull/999 and https://github.com/glideapps/glide-data-grid/pull/924. Feel free to comment again or open new issues if there are still issues with 6.0.4-alpha13.

lukasmasuch avatar Jun 25 '25 11:06 lukasmasuch