ENH(galaxies): NLA model for intrinsic alignments

[mwiet]

The ia_nla function computes the effective convergence from intrinsic alignments, calculated using the Non-linear Aligments Model (NLA). The convergence from intrinsic aligments is follows Catelan et al. (2000), Hirata & Seljak (2004), Bridle & King (2007).

Added: The new kappa_ia_nla() function computes an effective convergence due to Intrinsic Alignments using the NLA model. Reviewed-by: Nicolas Tessore Reviewed-by: Arthur Loureiro [email protected]

[arthurmloureiro]

Hi @mwiet,

Can you add documentation with references and equations to the docstring in the NLA model?

There are templates for this in the other functions :)

[mwiet]

Hi there! Thanks for letting me know! The documentation and references are now included in the function's docstring.

[ntessore]

Closing this, as the code is copied from the bornraytrace package without attribution. We will create an extension using that package instead.

[ntessore]

Ok, the issue has been resolved! I think we can try and merge this again. I will let @NiallJeffrey review this PR.

[mwiet]

Hi Nicolas,

I just tried to make the amendments to the changelog, but I don't seem to have the rights to push to the ia_nla branch anymore. Let me know how I can regain these.

Best,

Max

---

From: Nicolas Tessore @.> Sent: 17 May 2023 15:35 To: glass-dev/glass @.> Cc: Von Wietersheim-Kramsta, Maximilian @.>; Mention @.> Subject: Re: [glass-dev/glass] ENH: NLA model for intrinsic alignments (PR #21)

⚠ Caution: External sender

Hi @mwiethttps://github.com/mwiet, we are trying to get this into the next release. Could you take a look at CHANGELOG.mdhttps://github.com/glass-dev/glass/blob/main/CHANGELOG.md and add the corresponding entries for this PR to your branch? Cheers

— Reply to this email directly, view it on GitHubhttps://github.com/glass-dev/glass/pull/21#issuecomment-1551520238, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL36GZ4DGZQENO2BF7VSH7LXGTO4JANCNFSM54YS2YLA. You are receiving this because you were mentioned.Message ID: @.***>

[arthurmloureiro]

@ntessore I think we can merge this :)

[paddyroddy]

Have just updated from current main

[paddyroddy]

pre-commit.ci autofix

[paddyroddy]

Have addressed linting issues so that the CI passes. When the science is ready, this PR is ready to go 🙂

[arthurmloureiro]

From the science pov, both me and @mwiet have reviewed it and it seems solid.

But I think it would be great to have @NiallJeffrey to take a quick look :)

[paddyroddy]

Have done another update on this PR, just so it follows the practices in main - namely docstrings, mypy support etc. Looks like this in the docs

[ntessore]

I think this can finally go in.

@NiallJeffrey speak now or forever hold your peace 😉

[NiallJeffrey]

This looks good to me!

Comment -- it might be useful to put the C1 value in the docs, but it is the industry-standard value, so not essential

[paddyroddy]

I'm going to merge this before it falls stale again