react-native-pin-code icon indicating copy to clipboard operation
react-native-pin-code copied to clipboard
verified publisher icon gkueny

Found a couple issues so far

Open MrGurns opened this issue 7 years ago • 3 comments

Delete on android doesn't work, It does on iOS Underlines are drawn on Android, not on iOS (might want to use underlineColorAndroid='transparent') Styling differences amongst android and ios, Could better utilize the default styling to be justified and aligned instead of offsets.

MrGurns avatar Feb 12 '18 20:02 MrGurns

Furthermore, allowing entry into this for assigning a pin would also be cool. This would require a change to not auto set the focus, but to handle receiving it, as well as a value field, and very minimum an onChange() field. Utilizing the same layout as a TextField or other default input types from react native could prove useful.

MrGurns avatar Feb 12 '18 20:02 MrGurns

Hi !

Thanks for your comments !

  • "Delete on android doesn't work, It does on iOS" => Should be fixed with react-native 0.53

  • for your other remarks, I will take a look in the week, btw, PR is appreciated :)

gkueny avatar Feb 13 '18 08:02 gkueny

If i have some time here in the future, i may contribute. Currently have to get this app done first tho.

MrGurns avatar Feb 13 '18 16:02 MrGurns