WebSearcher icon indicating copy to clipboard operation
WebSearcher copied to clipboard

Remove self.params reset in prepare_search

Open darorck opened this issue 1 year ago • 1 comments

Remove the line that resets self.params in the SearchEngine class (prepare_search). This change allows for the addition of parameters such as gl or hl, enabling more flexible and targeted searches.

darorck avatar May 22 '24 09:05 darorck

Resetting the parameters upon each search call could break other scripts because location will persist if the reset is turned off, but wouldn't before. Arguments should be explicitly called on each search - happy to add these ones if you can update the PR accordingly. Would be great to hear more details about those parameters too (e.g., what do they change), and any documentation you can point to. See this recent PR and the corresponding merge for a recent arg I added that controls the number of results.

gitronald avatar May 28 '24 02:05 gitronald