GitPython icon indicating copy to clipboard operation
GitPython copied to clipboard

Not all of diff types documented and used in iter_change_type

Open worldmind opened this issue 6 years ago • 2 comments

Here, in comments five types described (not sure that this comment needed because same info in docstring), but below six types in change_type, in docstring here 5 types and here 5 types processed. Looks like type 'C' not described, but processed and 'T' described but not processed.

worldmind avatar Dec 06 '19 08:12 worldmind

Absolutely right, thanks a lot for taking the time to point this out. It would be great to see a PR to improve this, such that

  • the comment is deleted
  • the doc-string is updated to include the ‘C’ change type
  • the processing for the ‘T’ change type is added

Byron avatar Dec 08 '19 12:12 Byron

I will be glad to prepare a PR, but I am even can't understand what is going on in code because on first look it can be replace by such code:

for diff in self:
    yield diff

but may be I miss something and some diffs must be excluded from iteration?

worldmind avatar Dec 08 '19 12:12 worldmind