git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Switch from flow to typescript

Open machour opened this issue 7 years ago • 4 comments

As we were going through #770 with @housseindjirdeh, we both emitted the desire of ditching flow in favor of typescript.

I personally struggled with flow while trying to enforce types, using VS Code. Validation sometimes takes a few seconds, and the whole thing seems a bit sketchy to me.

Of course, this is up for debate :)

machour avatar Apr 12 '18 13:04 machour

I also have a preference for TS for a few reasons (one being a smoother editor experience). Thanks for logging this mate - and happy to hear anybody else's opinions on this as well 💬

housseindjirdeh avatar Apr 17 '18 21:04 housseindjirdeh

Would love to see this as well! Lmk if we're cool with me creating an initial PR for this.

G2Jose avatar May 04 '19 22:05 G2Jose

Whew, this is quite an old issue 😅.

Before any work is made here, let’s think about what real specific problems would typescript fix vs flow? Would it be worth it to make the change?

This amazing article from Eric Elliot talks about adopting typescript on big projects https://medium.com/javascript-scene/the-typescript-tax-132ff4cb175b I think it’s a good read before making this effort.

alejandronanez avatar May 05 '19 21:05 alejandronanez

Agreed with @alejandronanez. The main difference between them is that flow supports to be used progressively and it is already there. If created a new project, I will choose Typescript. And I don't think we can gain much benefits and have enough time to do that.

chinesedfan avatar May 06 '19 03:05 chinesedfan