git-point icon indicating copy to clipboard operation
git-point copied to clipboard
verified publisher icon gitpoint

Pinned repositories

Open gulien opened this issue 8 years ago • 5 comments

Hi,

This app looks promising, great work! 👍 It would be nice to have the pinned repositories on a user profil 😃

gulien avatar Jul 13 '17 12:07 gulien

Thank you so much :)

Yes this can be useful! Do you happen to have an idea of where you'd like to show it on the user profile page? Don't want to over-clutter the page, but some ideas:

  1. Show in the bottom section of the user profile page right above the Email SectionList (as another SectionList with just the list of pinned repositories
  2. Show ordered to the top in the RepositoryListScreen with an indicator of some sort

Leaning towards first one - but definitely open to all kinds of suggestions!

housseindjirdeh avatar Jul 13 '17 21:07 housseindjirdeh

Both options are cool, but I've a slighty preference for the first one 😁

gulien avatar Jul 13 '17 22:07 gulien

Agreed! 🎉

housseindjirdeh avatar Jul 13 '17 23:07 housseindjirdeh

Do you have some preference or idea on how retrieve a pinned repositories list?

Seems there is no easy way (endpoint) to get a user's pinned repos:

  1. With Github API v4, we have this possibility: https://stackoverflow.com/a/43358500
  2. Some libs (example: gh-pinned-repos) loads the user github page and extract the pinned repo from the DOM... Seems pretty "heavy"

Antoine38660 avatar Jul 16 '17 19:07 Antoine38660

Ah I was hoping there was an endpoint for it 😞

Ooooh so the GraphQL API has a way to retrieve that info. I definitely agree in that we shouldn't use a scraping tool to simply get the pinned repos. I'm okay with either option:

  1. Include GraphQL into our app and add this endpoint to retrieve pinned repositories. I haven't had the chance to use GraphQL but I've heard it's quite smooth to add an endpoint over a current REST implementation. We can open a separate issue to further explore the GraphQL API and if it makes sense to fully transition from REST (I've heard awesome things about it)
  2. Close this issue for now and possible open it later if we choose to explore GraphQL in the future

Definitely in favour of option 1, but open to all kinds of suggestions 💬

housseindjirdeh avatar Jul 16 '17 22:07 housseindjirdeh