Impossible to Override MaxLifetime

[Edward13ruf]

Bug description

Currently the MaxLifetime config in the ws-manager-mk2 is intended to allow admins to customize and set what the maximum length of time a workspace can be open before its shut down. However the logic says that the MaximumLifetime defined in the Workspace Spec takes precedence if it is present. This is sensible and allows for finer grained control on a per workspace case. However presently it is impossible for an admin to set or customize the value of that field. The entitlement service hard codes it to 36 hours, and it is always present on every workspace, thus the MaxLifetime option in the ws-manager-mk2 is never actually read or used.

Steps to reproduce

change the MaxLifetime option in the ws-manager-mk2 and then try and create a workspace that actually has that value.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

What would make more sense is if the lesser of the two timeouts was used, rather than always defaulting to the spec field if its present.

It would also be good to examine the logic in the entitlements section on the server to see if it can be made configurable.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.